Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752869AbbKID7R (ORCPT ); Sun, 8 Nov 2015 22:59:17 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:42649 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751705AbbKID7N (ORCPT ); Sun, 8 Nov 2015 22:59:13 -0500 Date: Mon, 9 Nov 2015 11:58:48 +0800 From: Herbert Xu To: Christoph Biedl Cc: maxime.ripard@free-electrons.com, clabbe.montjoie@gmail.com, davem@davemloft.net, wens@csie.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, stable@vger.kernel.org Subject: Re: [PATCH] crypto: sun4i-ss: add missing statesize Message-ID: <20151109035848.GA2163@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447006457@msgid.manchmal.in-ulm.de> Organization: Core X-Newsgroups: apana.lists.os.linux.cryptoapi,apana.lists.os.linux.kernel User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 28 Christoph Biedl wrote: > > Fixes: should rather point to the commit that caused the breakage in my > opinion. Which did this by intention: Absolutely not. That patch is correct and if you revert that you will simply end up registering a broken driver into the system that may then lead to crashes that can be triggered from user-space. > | commit 8996eafdcbad149ac0f772fb1649fbb75c482a6a > | Author: Russell King > | Date: Fri Oct 9 20:43:33 2015 +0100 > | > | crypto: ahash - ensure statesize is non-zero > (...) > + This patch adds a check to prevent these drivers from registering > + ahash algorithms until they are fixed. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/