Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753123AbbKIEYg (ORCPT ); Sun, 8 Nov 2015 23:24:36 -0500 Received: from ozlabs.org ([103.22.144.67]:32864 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589AbbKIEYZ (ORCPT ); Sun, 8 Nov 2015 23:24:25 -0500 From: Rusty Russell To: linux-kernel@vger.kernel.org Cc: Josh Poimboeuf , Peter Zijlstra , Rusty Russell , Peter Oberparleiter Subject: [PATCH 2/4] gcov: use within_module() helper. Date: Mon, 9 Nov 2015 14:53:55 +1030 Message-Id: <1447043037-10833-3-git-send-email-rusty@rustcorp.com.au> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1447043037-10833-1-git-send-email-rusty@rustcorp.com.au> References: <1447043037-10833-1-git-send-email-rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1510 Lines: 42 An exact mapping would be within_module_core(), but at this stage (MODULE_STATE_GOING) the init section is empty, and this is clearer. Cc: Peter Oberparleiter Signed-off-by: Rusty Russell --- kernel/gcov/base.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/gcov/base.c b/kernel/gcov/base.c index 7080ae1eb6c1..2f9df37940a0 100644 --- a/kernel/gcov/base.c +++ b/kernel/gcov/base.c @@ -123,11 +123,6 @@ void gcov_enable_events(void) } #ifdef CONFIG_MODULES -static inline int within(void *addr, void *start, unsigned long size) -{ - return ((addr >= start) && (addr < start + size)); -} - /* Update list and generate events when modules are unloaded. */ static int gcov_module_notifier(struct notifier_block *nb, unsigned long event, void *data) @@ -142,7 +137,7 @@ static int gcov_module_notifier(struct notifier_block *nb, unsigned long event, /* Remove entries located in module from linked list. */ while ((info = gcov_info_next(info))) { - if (within(info, mod->module_core, mod->core_size)) { + if (within_module((unsigned long)info, mod)) { gcov_info_unlink(prev, info); if (gcov_events_enabled) gcov_event(GCOV_REMOVE, info); -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/