Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751381AbbKIF2U (ORCPT ); Mon, 9 Nov 2015 00:28:20 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:42036 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbbKIF2R (ORCPT ); Mon, 9 Nov 2015 00:28:17 -0500 X-AuditID: cbfee68f-f796f6d0000014a4-8a-56402eef24b8 From: Alim Akhtar To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: JBottomley@odin.com, vinholikatti@gmail.com, gautam.vivek@samsung.com, essuuj@gmail.com, devicetree@vger.kernel.org, kishon@ti.com Subject: [PATCH v5 04/11] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Date: Mon, 09 Nov 2015 10:56:20 +0530 Message-id: <1447046787-480-5-git-send-email-alim.akhtar@samsung.com> X-Mailer: git-send-email 1.7.10.4 In-reply-to: <1447046787-480-1-git-send-email-alim.akhtar@samsung.com> References: <1447046787-480-1-git-send-email-alim.akhtar@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRmVeSWpSXmKPExsWyRsSkWve9nkOYwasTMhbzj5xjtVh+YQmT RduVg+wW/9ffZrG48LSHzeLyrjlsFt3Xd7BZ7FhY5cDhsXPWXXaPwz9+MHv0bVnF6HH8xnYm j8+b5AJYo7hsUlJzMstSi/TtErgyXt2fylgwU7hixtI7jA2M7QJdjJwcEgImEtfv32WBsMUk Ltxbz9bFyMUhJLCCUWLay0+sMEU39q+ASixllJjbNxOsQ0jgJ6PEu6k8IDabgLbE3elbmEBs EQEbifM3HzCBNDALdDBKdJ7bwgaSEBYIkfh2uI8RxGYRUJX4/7eRHcTmFXCV+PBvPzPENkWJ 7mcTwOo5Bdwkzs1sYIZY5irR9fokC8hQCYFl7BJ75t6EGiQg8W3yIaAEB1BCVmLTAag5khIH V9xgmcAovICRYRWjaGpBckFxUnqRsV5xYm5xaV66XnJ+7iZGYMCf/vesfwfj3QPWhxgFOBiV eHgjZtqHCbEmlhVX5h5iNAXaMJFZSjQ5HxhXeSXxhsZmRhamJqbGRuaWZkrivAulfgYLCaQn lqRmp6YWpBbFF5XmpBYfYmTi4JRqYIwU2us+x77sh9oX9bdRy3+IfuYQLNuxL/WAXN+SuI/6 k+vZ2PoTZ+XztCucquVwezffPalzScsJFt34MwZiNlfkhTyNvjlc4Tuxs7YkiPttbDar7ff5 BhyTmV5xqn+6e1mY9eRvPjlZ4aKPrMna7j6ZincuHA+dYqizYWtMxPTwjQkFvjvilViKMxIN tZiLihMBIuCAh3MCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsVy+t9jAd33eg5hBkdPCljMP3KO1WL5hSVM Fm1XDrJb/F9/m8XiwtMeNovLu+awWXRf38FmsWNhlQOHx85Zd9k9Dv/4wezRt2UVo8fxG9uZ PD5vkgtgjWpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1 y8wBukVJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmPHq/lTGgpnCFTOW 3mFsYGwX6GLk5JAQMJG4sX8FG4QtJnHh3nogm4tDSGApo8TcvpksIAkhgZ+MEu+m8oDYbALa Enenb2ECsUUEbCTO33zABNLALNDBKNF5bgvYJGGBEIlvh/sYQWwWAVWJ/38b2UFsXgFXiQ// 9jNDbFOU6H42AayeU8BN4tzMBmaIZa4SXa9Pskxg5F3AyLCKUSK1ILmgOCk91zAvtVyvODG3 uDQvXS85P3cTIziqnkntYDy4y/0QowAHoxIPL8N0+zAh1sSy4srcQ4wSHMxKIrxmbA5hQrwp iZVVqUX58UWlOanFhxhNgQ6byCwlmpwPjPi8knhDYxNzU2NTSxMLEzNLJXFefU+jMCGB9MSS 1OzU1ILUIpg+Jg5OqQZG4V+KF0zXy5dt+Vn1yF9dqm7btaXvw+8a7Guqa96i8G9bgW3jA9UM o3p9IcnFa+u2Kha7q8kn73lXyHvqX2k7+/s993ka1pz+cPDdte0ZujffSsYtL1jesUW0oP1a BecdfcUNFSWb/uss/nz69hnxTr1rx5xq46Tr+eIe2dbzXOaImVmrU26qxFKckWioxVxUnAgA 5XUNxMACAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2631 Lines: 76 From: Seungwon Jeon In the right behavior, setting the bit to '0' indicates clear and '1' indicates no change. If host contoller handles this the other way, UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR can be used. Signed-off-by: Seungwon Jeon Signed-off-by: Alim Akhtar --- drivers/scsi/ufs/ufshcd.c | 21 +++++++++++++++++++-- drivers/scsi/ufs/ufshcd.h | 5 +++++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 587a9c8fbfe9..2b16eb363203 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -356,7 +356,24 @@ static inline void ufshcd_put_tm_slot(struct ufs_hba *hba, int slot) */ static inline void ufshcd_utrl_clear(struct ufs_hba *hba, u32 pos) { - ufshcd_writel(hba, ~(1 << pos), REG_UTP_TRANSFER_REQ_LIST_CLEAR); + if (hba->quirks & UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR) + ufshcd_writel(hba, (1 << pos), REG_UTP_TRANSFER_REQ_LIST_CLEAR); + else + ufshcd_writel(hba, ~(1 << pos), + REG_UTP_TRANSFER_REQ_LIST_CLEAR); +} + +/** + * ufshcd_utmrl_clear - Clear a bit in UTRMLCLR register + * @hba: per adapter instance + * @pos: position of the bit to be cleared + */ +static inline void ufshcd_utmrl_clear(struct ufs_hba *hba, u32 pos) +{ + if (hba->quirks & UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR) + ufshcd_writel(hba, (1 << pos), REG_UTP_TASK_REQ_LIST_CLEAR); + else + ufshcd_writel(hba, ~(1 << pos), REG_UTP_TASK_REQ_LIST_CLEAR); } /** @@ -3685,7 +3702,7 @@ static int ufshcd_clear_tm_cmd(struct ufs_hba *hba, int tag) goto out; spin_lock_irqsave(hba->host->host_lock, flags); - ufshcd_writel(hba, ~(1 << tag), REG_UTP_TASK_REQ_LIST_CLEAR); + ufshcd_utmrl_clear(hba, tag); spin_unlock_irqrestore(hba->host->host_lock, flags); /* poll for max. 1 sec to clear door bell register by h/w */ diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index 6cd542a803d5..d625d01110b0 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -474,6 +474,11 @@ struct ufs_hba { */ #define UFSHCI_QUIRK_BYTE_ALIGN_UTRD UFS_BIT(6) + /* + * Cleaer handling for transfer/task request list is just opposite. + */ + #define UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR UFS_BIT(7) + unsigned int quirks; /* Deviations from standard UFSHCI spec. */ wait_queue_head_t tm_wq; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/