Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbbKIFqE (ORCPT ); Mon, 9 Nov 2015 00:46:04 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42899 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752671AbbKIFp6 (ORCPT ); Mon, 9 Nov 2015 00:45:58 -0500 Subject: Re: [PATCH] acpi: add support for extended IRQ to PCI link To: Jiang Liu , linux-acpi@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com References: <1446998832-7023-1-git-send-email-okaya@codeaurora.org> <56402E23.1070805@linux.intel.com> Cc: agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Rafael J. Wysocki" , Len Brown , linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: <56403311.2020806@codeaurora.org> Date: Mon, 9 Nov 2015 00:45:53 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56402E23.1070805@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 48 On 11/9/2015 12:24 AM, Jiang Liu wrote: >> + u32 possible[ACPI_PCI_LINK_MAX_POSSIBLE]; >> > u8 initialized:1; >> > u8 reserved:7; >> > }; > Hi Sinan, > This data structure become some sort of big, any idea to reduce > memory consumption? > Thanks, > Gerry > Hi Gerry, There are two constants in the code. #define ACPI_PCI_LINK_MAX_POSSIBLE 16 I changed the data type above. Previously it was consuming 16 bytes now 64 bytes. The second one is this. #define ACPI_MAX_IRQS 256 I changed ACPI_MAX_IRQS to 1020 from 256. Let's assume 1024. I'm concerned about this though since you warned. This used to consume 1024 bytes now 4096 bytes. static int acpi_irq_penalty[ACPI_MAX_IRQS] = { PIRQ_PENALTY_ISA_ALWAYS, /* IRQ0 timer */ ... } Sinan -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/