Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168AbbKIHYh (ORCPT ); Mon, 9 Nov 2015 02:24:37 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33524 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833AbbKIHYe (ORCPT ); Mon, 9 Nov 2015 02:24:34 -0500 From: Joonsoo Kim X-Google-Original-From: Joonsoo Kim To: Andrew Morton Cc: Michal Nazarewicz , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim Subject: [PATCH 2/3] mm/cma: add new tracepoint, test_pages_isolated Date: Mon, 9 Nov 2015 16:24:20 +0900 Message-Id: <1447053861-28824-2-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1447053861-28824-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1447053861-28824-1-git-send-email-iamjoonsoo.kim@lge.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2252 Lines: 79 cma allocation should be guranteeded to succeed, but, sometimes, it could be failed in current implementation. To track down the problem, we need to know which page is problematic and this new tracepoint will report it. Signed-off-by: Joonsoo Kim --- include/trace/events/cma.h | 26 ++++++++++++++++++++++++++ mm/page_isolation.c | 5 +++++ 2 files changed, 31 insertions(+) diff --git a/include/trace/events/cma.h b/include/trace/events/cma.h index d7cd961..82281b0 100644 --- a/include/trace/events/cma.h +++ b/include/trace/events/cma.h @@ -60,6 +60,32 @@ TRACE_EVENT(cma_release, __entry->count) ); +TRACE_EVENT(test_pages_isolated, + + TP_PROTO( + unsigned long start_pfn, + unsigned long end_pfn, + unsigned long fin_pfn), + + TP_ARGS(start_pfn, end_pfn, fin_pfn), + + TP_STRUCT__entry( + __field(unsigned long, start_pfn) + __field(unsigned long, end_pfn) + __field(unsigned long, fin_pfn) + ), + + TP_fast_assign( + __entry->start_pfn = start_pfn; + __entry->end_pfn = end_pfn; + __entry->fin_pfn = fin_pfn; + ), + + TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s", + __entry->start_pfn, __entry->end_pfn, __entry->fin_pfn, + __entry->end_pfn == __entry->fin_pfn ? "success" : "fail") +); + #endif /* _TRACE_CMA_H */ /* This part must be outside protection */ diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 6f5ae96..bda0fea 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -7,6 +7,8 @@ #include #include #include +#include + #include "internal.h" static int set_migratetype_isolate(struct page *page, @@ -268,6 +270,9 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, skip_hwpoisoned_pages); spin_unlock_irqrestore(&zone->lock, flags); +#ifdef CONFIG_CMA + trace_test_pages_isolated(start_pfn, end_pfn, pfn); +#endif return (pfn < end_pfn) ? -EBUSY : 0; } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/