Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbbKIHu6 (ORCPT ); Mon, 9 Nov 2015 02:50:58 -0500 Received: from mx5-phx2.redhat.com ([209.132.183.37]:36865 "EHLO mx5-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833AbbKIHuz (ORCPT ); Mon, 9 Nov 2015 02:50:55 -0500 Date: Mon, 9 Nov 2015 02:50:52 -0500 (EST) From: Benjamin Tissoires To: Elias Vanderstuyft Cc: Dmitry Torokhov , David Herrmann , Peter Hutterer , "open list:HID CORE LAYER" , linux-kernel@vger.kernel.org Message-ID: <46665760.4161715.1447055452531.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1440515579-5359-1-git-send-email-benjamin.tissoires@redhat.com> Subject: Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.3.113.36] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF41 (Linux)/8.0.6_GA_5922) Thread-Topic: Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl Thread-Index: OdTBt0sLdfxX/dmkyDU44KEVSO3Scw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2829 Lines: 82 ----- Original Message ----- > From: "Elias Vanderstuyft" > To: "Benjamin Tissoires" > Cc: "Dmitry Torokhov" , "David Herrmann" , "Peter Hutterer" > , "open list:HID CORE LAYER" , linux-kernel@vger.kernel.org > Sent: Sunday, November 8, 2015 11:55:04 AM > Subject: Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl > > Hi, > > On Tue, Aug 25, 2015 at 5:12 PM, Benjamin Tissoires > wrote: > > diff --git a/include/uapi/linux/uinput.h b/include/uapi/linux/uinput.h > > index 013c9d8..ef6c9f5 100644 > > --- a/include/uapi/linux/uinput.h > > +++ b/include/uapi/linux/uinput.h > > @@ -20,6 +20,11 @@ > > * Author: Aristeu Sergio Rozanski Filho > > * > > * Changes/Revisions: > > + * 0.5 08/13/2015 (David Herrmann & > > + * Benjamin Tissoires > > ) > > + * - add UI_DEV_SETUP ioctl > > + * - add UI_ABS_SETUP ioctl > > + * - add UI_GET_VERSION ioctl > > * 0.4 01/09/2014 (Benjamin Tissoires > > ) > > * - add UI_GET_SYSNAME ioctl > > * 0.3 24/05/2006 (Anssi Hannula ) > > @@ -37,8 +42,8 @@ > > #include > > #include > > > > -#define UINPUT_VERSION 4 > > - > > +#define UINPUT_VERSION 5 > > +#define UINPUT_MAX_NAME_SIZE 80 > > > > struct uinput_ff_upload { > > __u32 request_id; > > @@ -58,6 +63,79 @@ struct uinput_ff_erase { > > #define UI_DEV_CREATE _IO(UINPUT_IOCTL_BASE, 1) > > #define UI_DEV_DESTROY _IO(UINPUT_IOCTL_BASE, 2) > > > > +struct uinput_setup { > > + struct input_id id; > > + char name[UINPUT_MAX_NAME_SIZE]; > > + __u32 ff_effects_max; > > +}; > > Is there a reason to not follow the same field order as in struct > uinput_user_dev? Not really, no. > I.e., why not: > > struct uinput_setup { > char name[UINPUT_MAX_NAME_SIZE]; > struct input_id id; > __u32 ff_effects_max; > }; > > In case you would change this, also make sure to change the order in > the documentation of UI_DEV_SETUP. > Works for me. Dmitry, how do you want to handle this change? Me re-sending the whole series or you applying the change directly on your tree? Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/