Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752616AbbKIKAJ (ORCPT ); Mon, 9 Nov 2015 05:00:09 -0500 Received: from lucky1.263xmail.com ([211.157.147.130]:46178 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbbKIKAH (ORCPT ); Mon, 9 Nov 2015 05:00:07 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: lyz@rock-chips.com X-FST-TO: rockchip-discuss@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: lyz@rock-chips.com X-UNIQUE-TAG: <9c9954be723aed311073529fc84a6c89> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RFC] usb: dwc2: hcd: fix split schedule issue To: Doug Anderson References: <1446802612-5828-1-git-send-email-lyz@rock-chips.com> Cc: John Youn , Julius Werner , Dinh Nguyen , "Kaukab, Yousaf" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , wulf , Kever Yang , caesar , Tao Huang , rockchip-discuss From: Yunzhi Li Message-ID: <56406E09.4030903@rock-chips.com> Date: Mon, 9 Nov 2015 17:57:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2114 Lines: 52 hi Doug 在 2015/11/7 7:56, Doug Anderson 写道: > lyz@, > > On Fri, Nov 6, 2015 at 1:36 AM, Yunzhi Li wrote: >> Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN >> packet between SSPLIT-begin and SSPLIT-end. >> >> Signed-off-by: Yunzhi Li >> --- >> drivers/usb/dwc2/hcd.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c >> index e79baf7..a32ed01 100644 >> --- a/drivers/usb/dwc2/hcd.c >> +++ b/drivers/usb/dwc2/hcd.c >> @@ -1122,6 +1122,10 @@ static void dwc2_process_periodic_channels(struct dwc2_hsotg *hsotg) >> break; >> } >> >> + if (qh->channel->xact_pos == DWC2_HCSPLT_XACTPOS_BEGIN || >> + qh->channel->xact_pos == DWC2_HCSPLT_XACTPOS_MID) >> + break; >> + >> /* >> * In Slave mode, stay on the current transfer until there is >> * nothing more to do or the high-bandwidth request count is > Just a quite note to say that this doesn't seem to resolve the weird > errors I'm seeing with the "Microsoft Wireless Keyboard 2000" that I > have. I see split transaction errors in a USB analyzer with just that > hooked up behind a hub (don't even need any other USB devices). > > ...it is possible that there are two unrelated problems here, but it's > also possible that there's some bigger root cause that will fix both > of our problems. I've been poking at things a bit too, but so far no > luck... > > -Doug > It seems that we are debugging two different issues, your new patch which rewrite the microframe scheduler doesn't resolve my problem. My patch fix chrome-os issue #46547 not related to the particular Microsoft keyboard any keyboard could be used to reproduce the issue. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/