Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752724AbbKIK0Z (ORCPT ); Mon, 9 Nov 2015 05:26:25 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:5286 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbbKIK0W (ORCPT ); Mon, 9 Nov 2015 05:26:22 -0500 Date: Mon, 9 Nov 2015 11:25:55 +0100 From: Ludovic Desroches To: Ulf Hansson CC: Nicolas Ferre , Alexandre Belloni , linux-mmc , "linux-kernel@vger.kernel.org" , Jean-Christophe Plagniol-Villard , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , , Ludovic Desroches Subject: Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply Message-ID: <20151109102555.GA15706@odux.rfo.atmel.com> Mail-Followup-To: Ulf Hansson , Nicolas Ferre , Alexandre Belloni , linux-mmc , "linux-kernel@vger.kernel.org" , Jean-Christophe Plagniol-Villard , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , pierre.samat@atmel.com References: <1446825570-30029-1-git-send-email-ludovic.desroches@atmel.com> <20151109074104.GB27482@odux.rfo.atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2236 Lines: 55 On Mon, Nov 09, 2015 at 10:38:03AM +0100, Ulf Hansson wrote: > [...] > > >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case it is > >> > not really driven by a gpio but by a pio from the sdhci device. In the binding, > >> > >> What's a "pio"? > >> > >> What do you mean by the it's driven from the sdhci device? > >> > > > > Sorry I mean sdhci device from the SoC point of view, I should say > > controller. So yes the signal is driven by the controller. > > > >> Is it the internal HW logic of the sdhci controller that manages the > >> IO voltage? And this logic can be controlled via certain register bits > >> in the SDHCI controller? > >> > > > > Yes, it depends of the value of the '1.8V Signaling Enable' value in the > > host control 2 register. > > > >> > declaring the gpio is an option so I thought using this regulator fits my need. > >> > >> In quite many cases it makes sense to model this though a gpio > >> regulator. For example when you use a level shifter circuit. Those > >> normally have gpio pin routed to control the voltage level output for > >> the signals. For example switching between 1.8V and 2.9V. > >> > > > > I agree, my concern is to know if I can consider it as a 'general' pio > > since it is driven by the sdhci controller. > > This doesn't seems like a case where a gpio regulator should be used > and I am not sure what problem it would solve. Beside to suppress the > log warnings (actually those aren't warnings but informations). > > Isn't sdhci_do_start_signal_voltage_switch() doing what you need here? > It is. I am only wondering the best way to describe the hardware: - No regulator but I have the 'no vqmmc regulator not found' message which is a bit annoying and which can be interpreted as an issue for someone who has no knowledge about this stuff. - Describe the regulator since there is one on my board. But it is not a fixed regulator and even if it's close to a gpio one it is not. Regards Ludovic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/