Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbbKILTs (ORCPT ); Mon, 9 Nov 2015 06:19:48 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:34361 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753734AbbKILTp (ORCPT ); Mon, 9 Nov 2015 06:19:45 -0500 Date: Mon, 9 Nov 2015 16:49:39 +0530 From: Sudip Mukherjee To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , James Simmons , Linux Kernel Mailing List , lustre-devel@lists.lustre.org Subject: Re: [PATCH] staging: lustre: Handle nodemask on UMP machines Message-ID: <20151109111939.GB3868@sudip-pc> References: <1447000500-29427-1-git-send-email-jsimmons@infradead.org> <1447000500-29427-2-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447000500-29427-2-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1846 Lines: 43 On Sun, Nov 08, 2015 at 11:34:55AM -0500, James Simmons wrote: > For UMP and SMP machines the struct cfs_cpt_table are > defined differently. In the case handled by this patch > nodemask is defined as a integer for the UMP case and > as a pointer for the SMP case. This will cause a problem > for ost_setup which reads the nodemask directly. Instead > we create a UMP version of cfs_cpt_nodemask and use that > in ost_setup. > > Signed-off-by: James Simmons > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4199 > Reviewed-on: http://review.whamcloud.com/9219 > Reviewed-by: Liang Zhen > Reviewed-by: Li Xi > Reviewed-by: Andreas Dilger Signed-off-by: and Reviewed-by: tags entered two times. Once here. > > Starting in 3.14 kernels nodemask_t was changed from a > a unsigned long to a linux bitmap so more than 32 cores > could be supported. Using set_bit in cfs_cpt_table_alloc > no longer compiles so this patch backports bits of the > node management function that use a linux bitmap back > end. Cleaned up libcfs bitmap.h to use the libcfs layers > memory allocation function. This was pulling in lustre > related code that was not defined. > > Signed-off-by: James Simmons > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4993 > Reviewed-on: http://review.whamcloud.com/10332 > Reviewed-by: Liang Zhen > Reviewed-by: Bob Glossman > Reviewed-by: Oleg Drokin And then again here. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/