Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752428AbbKINPI (ORCPT ); Mon, 9 Nov 2015 08:15:08 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:23372 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752176AbbKINPE (ORCPT ); Mon, 9 Nov 2015 08:15:04 -0500 Date: Mon, 9 Nov 2015 14:14:37 +0100 From: Ludovic Desroches To: Ulf Hansson CC: Nicolas Ferre , Alexandre Belloni , linux-mmc , "linux-kernel@vger.kernel.org" , Jean-Christophe Plagniol-Villard , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , , Ludovic Desroches Subject: Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply Message-ID: <20151109131437.GB15706@odux.rfo.atmel.com> Mail-Followup-To: Ulf Hansson , Nicolas Ferre , Alexandre Belloni , linux-mmc , "linux-kernel@vger.kernel.org" , Jean-Christophe Plagniol-Villard , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , pierre.samat@atmel.com References: <1446825570-30029-1-git-send-email-ludovic.desroches@atmel.com> <20151109074104.GB27482@odux.rfo.atmel.com> <20151109102555.GA15706@odux.rfo.atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 38 On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: > [...] > > >> > >> This doesn't seems like a case where a gpio regulator should be used > >> and I am not sure what problem it would solve. Beside to suppress the > >> log warnings (actually those aren't warnings but informations). > >> > >> Isn't sdhci_do_start_signal_voltage_switch() doing what you need here? > >> > > > > It is. I am only wondering the best way to describe the hardware: > > - No regulator but I have the 'no vqmmc regulator not found' message which > > is a bit annoying and which can be interpreted as an issue for someone > > who has no knowledge about this stuff. > > Hmm, should we turn them into debug messages? Both regulators are optional. > I think so. From my point of view, it is useless to indicate that something optionnal is missing. > > - Describe the regulator since there is one on my board. But it is not a > > fixed regulator and even if it's close to a gpio one it is not. > > If it's driven by SDHCI internal logic, I would leave it to that. > There are no need to describe it at all. Ok thanks for your help. > > Kind regards > Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/