Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbbKINSn (ORCPT ); Mon, 9 Nov 2015 08:18:43 -0500 Received: from mail-yk0-f173.google.com ([209.85.160.173]:35845 "EHLO mail-yk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbbKINSk (ORCPT ); Mon, 9 Nov 2015 08:18:40 -0500 MIME-Version: 1.0 In-Reply-To: <20151109131437.GB15706@odux.rfo.atmel.com> References: <1446825570-30029-1-git-send-email-ludovic.desroches@atmel.com> <20151109074104.GB27482@odux.rfo.atmel.com> <20151109102555.GA15706@odux.rfo.atmel.com> <20151109131437.GB15706@odux.rfo.atmel.com> Date: Mon, 9 Nov 2015 14:18:40 +0100 Message-ID: Subject: Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply From: Ulf Hansson To: Ulf Hansson , Nicolas Ferre , Alexandre Belloni , linux-mmc , "linux-kernel@vger.kernel.org" , Jean-Christophe Plagniol-Villard , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , pierre.samat@atmel.com Cc: Ludovic Desroches Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 33 On 9 November 2015 at 14:14, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: >> [...] >> >> >> >> >> This doesn't seems like a case where a gpio regulator should be used >> >> and I am not sure what problem it would solve. Beside to suppress the >> >> log warnings (actually those aren't warnings but informations). >> >> >> >> Isn't sdhci_do_start_signal_voltage_switch() doing what you need here? >> >> >> > >> > It is. I am only wondering the best way to describe the hardware: >> > - No regulator but I have the 'no vqmmc regulator not found' message which >> > is a bit annoying and which can be interpreted as an issue for someone >> > who has no knowledge about this stuff. >> >> Hmm, should we turn them into debug messages? Both regulators are optional. >> > > I think so. From my point of view, it is useless to indicate that > something optionnal is missing. Okay. Please go ahead and send a patch. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/