Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbbKINcQ (ORCPT ); Mon, 9 Nov 2015 08:32:16 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:33019 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751860AbbKINcL (ORCPT ); Mon, 9 Nov 2015 08:32:11 -0500 MIME-Version: 1.0 In-Reply-To: <1446766950-31213-1-git-send-email-aduggan@synaptics.com> References: <1446766950-31213-1-git-send-email-aduggan@synaptics.com> Date: Mon, 9 Nov 2015 14:32:10 +0100 Message-ID: Subject: Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support From: Linus Walleij To: Andrew Duggan Cc: Linux Input , "linux-kernel@vger.kernel.org" , Benjamin Tissoires , Dmitry Torokhov , Benjamin Tissoires , Christopher Heiny , Stephen Chandler Paul , Allie Xiong Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1187 Lines: 31 On Fri, Nov 6, 2015 at 12:42 AM, Andrew Duggan wrote: > From: Benjamin Tissoires > > RMI4 Function 0x30 provides support for GPIOs, LEDs and mechanical > buttons. In particular, the mechanical button support is used in > an increasing number of touchpads. > > [BT] cured the code to rely only on the unified input node created > by rmi_driver. > > Signed-off-by: Andrew Duggan > Signed-off-by: Allie Xiong > Signed-off-by: Benjamin Tissoires I see this function driver is not yet adding any gpio_chip or LEDs class devices, which is fine, we can add that later when we have something to test. Or is iit using that LED feature in the input layer that corresponds to caps lock etc? I don't quite get it I guess :/ But I guess it should also be squashed into the original F30 driver. Yours, Linus Waleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/