Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752182AbbKINiG (ORCPT ); Mon, 9 Nov 2015 08:38:06 -0500 Received: from mail-oi0-f52.google.com ([209.85.218.52]:35017 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbbKINiD (ORCPT ); Mon, 9 Nov 2015 08:38:03 -0500 MIME-Version: 1.0 In-Reply-To: <1446767000-31398-1-git-send-email-aduggan@synaptics.com> References: <1446767000-31398-1-git-send-email-aduggan@synaptics.com> Date: Mon, 9 Nov 2015 14:38:02 +0100 Message-ID: Subject: Re: [PATCH 26/26] Input: synaptics-rmi4: Change the rmi device's name to be less generic From: Linus Walleij To: Andrew Duggan Cc: Linux Input , "linux-kernel@vger.kernel.org" , Dmitry Torokhov , Benjamin Tissoires , Christopher Heiny , Stephen Chandler Paul Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1107 Lines: 26 On Fri, Nov 6, 2015 at 12:43 AM, Andrew Duggan wrote: > Currently, the rmi device has the name sensorXX. Sensor is very generic > and in cases when there is little context it is hard to tell what the > device is (ie in /sys/devices or /proc/interrupts). This patch changes > the name to rmiXX which at least indicates that it is an rmi device. > > Signed-off-by: Andrew Duggan > --- > Linus Walleij suggested that we use the TM number as the device name. > But, we need to set the device name when we add the device before we > read the TM number. Changing the name to rmiXX is a compromise since > it's not as unique as the TM, but not as generic as sensor. OK OK I give up. No big deal anyway, the device works. Squash into core patch? Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/