Date: Tue, 25 Feb 2003 13:33:50 +0530
From: Maneesh Soni <maneesh@in.ibm.com>
To: braam@clusterfs.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       David Ford <david+cert@blue-labs.org>
Subject: Re: [OOPS] 2.5.62, bootup, do_add_mount
Message-ID: <20030225080350.GD1109@in.ibm.com>
Reply-To: maneesh@in.ibm.com
References: <3E5700EA.9070905@blue-labs.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3E5700EA.9070905@blue-labs.org>
User-Agent: Mutt/1.4i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3981
Lines: 103


Hi Peter,

presto_get_sb() is returning error resulting in the following NULL 
pointer reference in do_kern_mount(). The following patch corrects
it.

Please let me know if it is correct or not.

Thanks
Maneesh

diff -urN linux-2.5.63-base/fs/intermezzo/super.c linux-2.5.63-presto_get_sb/fs/intermezzo/super.c
--- linux-2.5.63-base/fs/intermezzo/super.c	2003-02-25 00:36:01.000000000 +0530
+++ linux-2.5.63-presto_get_sb/fs/intermezzo/super.c	2003-02-25 13:19:11.000000000 +0530
@@ -318,7 +318,7 @@
 
         CDEBUG(D_MALLOC, "mount error exit: kmem %ld, vmem %ld\n",
                presto_kmemory, presto_vmemory);
-        return NULL;
+        return sb;
 }
 
On Sat, Feb 22, 2003 at 04:51:39AM +0000, David Ford wrote:
> Pentium II, kernel compiled with gcc 2.95.3
> 
> [...]
> 802.1Q VLAN Support v1.8 Ben Greear <greearb@candelatech.com>
> All bugs added by David S. Miller <davem@redhat.com>
> BIOS EDD facility v0.09 2003-Jan-22, 3 devices found
> ACPI: (supports S0 S1 S4 S5)
> Started krxiod 12
> Started krxsecd 13
> (filter_get_filter_fs,l. 234): ops at c05d4918
> (fs/intermezzo/super.c:presto_get_sb,l. 253 1): Presto: unrecognized fs 
> type or cache type
> Unable to handle kernel NULL pointer dereference at virtual address 0000003c
> printing eip:
> c016a6a4
> *pde = 00000000
> Oops: 0000
> CPU:    0
> EIP:    0060:[<c016a6a4>]    Not tainted
> EFLAGS: 00010217
> EIP is at do_kern_mount+0x58/0xa8
> eax: 00000000   ebx: c3fe9720   ecx: c3f55000   edx: c3f55010
> esi: 00000000   edi: c05124a0   ebp: c3fcbee0   esp: c3fcbed4
> ds: 007b   es: 007b   ss: 0068
> Process swapper (pid: 1, threadinfo=c3fca000 task=c3fc8000)
> Stack: 00008001 c3fca000 c3e2800a c3fcbf04 c0186546 c3e28000 00008001 
> c11ff000
>       00000000 00008001 00000000 c3fcbf38 c3fcbf54 c018683d c3fcbf38 
> c3e28000
>       00008001 00000000 c11ff000 00000000 c3fca000 00000001 c3e29000 
> c11ff000
> Call Trace:
> [<c0186546>] do_add_mount+0x62/0x150
> [<c018683d>] do_mount+0x139/0x150
> [<c018718e>] sys_mount+0x136/0x224
> [<c010545e>] prepare_namespace+0xfe/0x140
> [<c01051a5>] init+0xcd/0x288
> [<c01050d8>] init+0x0/0x288
> [<c0107211>] kernel_thread_helper+0x5/0xc
> 
> Code: 8b 46 3c 85 c0 74 06 ff 00 80 48 04 08 89 43 10 8b 46 3c 89
> <0>Kernel panic: Attempted to kill init!
> 
> -- 
> I may have the information you need and I may choose only HTML.  It's up to 
> you. Disclaimer: I am not responsible for any email that you send me nor am 
> I bound to any obligation to deal with any received email in any given 
> fashion.  If you send me spam or a virus, I may in whole or part send you 
> 50,000 return copies of it. I may also publically announce any and all 
> emails and post them to message boards, news sites, and even parody sites.  
> I may also mark them up, cut and paste, print, and staple them to telephone 
> poles for the enjoyment of people without internet access.  This is not a 
> confidential medium and your assumption that your email can or will be 
> handled confidentially is akin to baring your backside, burying your head 
> in the ground, and thinking nobody can see you butt nekkid and in plain 
> view for miles away.  Don't be a cluebert, buy one from K-mart today.
> 
> When it absolutely, positively, has to be destroyed overnight.
>                           AIR FORCE
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Maneesh Soni
IBM Linux Technology Center, 
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: maneesh@in.ibm.com
http://lse.sourceforge.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/