Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318AbbKIN65 (ORCPT ); Mon, 9 Nov 2015 08:58:57 -0500 Received: from mail-yk0-f179.google.com ([209.85.160.179]:35786 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbbKIN6y (ORCPT ); Mon, 9 Nov 2015 08:58:54 -0500 MIME-Version: 1.0 In-Reply-To: <1447075429-27311-5-git-send-email-jonathanh@nvidia.com> References: <1447075429-27311-1-git-send-email-jonathanh@nvidia.com> <1447075429-27311-5-git-send-email-jonathanh@nvidia.com> Date: Mon, 9 Nov 2015 15:58:51 +0200 Message-ID: Subject: Re: [PATCH V2 4/6] dmaengine: tegra-apb: Only save channel state for those in use From: Andy Shevchenko To: Jon Hunter Cc: Laxman Dewangan , Vinod Koul , Stephen Warren , Thierry Reding , Alexandre Courbot , dmaengine , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 28 On Mon, Nov 9, 2015 at 3:23 PM, Jon Hunter wrote: > Currently the tegra-apb DMA driver suspend/resume helpers, save and > restore the registers for all channels regardless of whether they are > in use or not. Change this so that only channels that have been > allocated and configured are saved and restored. Nitpick > + /* > + * Only save the state of DMA channels that are in use. > + */ One line? > + /* > + * Only restore the state of DMA channels that are in use. > + */ Same. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/