Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbbKIOQO (ORCPT ); Mon, 9 Nov 2015 09:16:14 -0500 Received: from mail.kernel.org ([198.145.29.136]:34335 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbbKIOQK (ORCPT ); Mon, 9 Nov 2015 09:16:10 -0500 Date: Mon, 9 Nov 2015 11:16:05 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Namhyung Kim , Jiri Olsa Subject: Re: [PATCH] perf tools: Correct typing errors about '-' or '_' in config variable. Message-ID: <20151109141605.GK13236@kernel.org> References: <1447066475-25543-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447066475-25543-1-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2552 Lines: 78 Em Mon, Nov 09, 2015 at 07:54:35PM +0900, Taeung Song escreveu: > To improve perf config usability, we should probably also recognize > underscores in perf config entries, i.e. the following variants > should both work: as suggested by Ingo Molnar > > print_percent = 1 > print-percent = 1 > > So, add functionality for it. > 'annotate' section has variables that contain '_' underscores like: > > hide_src_code > use_offset > jump_arrows > show_nr_jumps > > However other sections has variables that contain a '-' dash > or neither it or underscore i.e. > > ui.show-headers > call-graph.print-limit > tui.report There is no need to single our a section just because nowadays it contains underscores so that we would convert them to dashes, do it for all sections, so that if in the future we get underscores in them, then it wild be dash/underscore "insensitive". In fact, this would be a strcasecmp_() routine, i.e. one that would, in addition to being case insensitive, also consider - and _ the same character. - Arnaldo > So, convert the characters if typing errors about underscores > or a dash when parsing the config file. > > Cc: Namhyung Kim > Cc: Jiri Olsa > Signed-off-by: Taeung Song > --- > tools/perf/util/config.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c > index 2e452ac..69db606 100644 > --- a/tools/perf/util/config.c > +++ b/tools/perf/util/config.c > @@ -129,7 +129,10 @@ static int get_value(config_fn_t fn, void *data, char *name, unsigned int len) > { > int c; > char *value; > + bool has_underscore = false; > > + if (prefixcmp(name, "annotate.") == 0) > + has_underscore = true; > /* Get the full name */ > for (;;) { > c = get_next_char(); > @@ -137,6 +140,11 @@ static int get_value(config_fn_t fn, void *data, char *name, unsigned int len) > break; > if (!iskeychar(c)) > break; > + /* Correct typing errors about dash or underscore */ > + if (has_underscore && c == '-') > + c = '_'; > + else if (!has_underscore && c == '_') > + c = '-'; > name[len++] = c; > if (len >= MAXNAME) > return -1; > -- > 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/