Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbbKIOQV (ORCPT ); Mon, 9 Nov 2015 09:16:21 -0500 Received: from mail-yk0-f179.google.com ([209.85.160.179]:35931 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbbKIOQQ (ORCPT ); Mon, 9 Nov 2015 09:16:16 -0500 MIME-Version: 1.0 In-Reply-To: References: <1446738939-22320-1-git-send-email-clabbe.montjoie@gmail.com> Date: Mon, 9 Nov 2015 16:16:16 +0200 Message-ID: Subject: Re: [PATCH] gpio: 74xx: fix a possible NULL dereference From: Andy Shevchenko To: Alexandre Courbot Cc: LABBE Corentin , Linus Walleij , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 39 On Mon, Nov 9, 2015 at 2:21 AM, Alexandre Courbot wrote: > On Fri, Nov 6, 2015 at 12:55 AM, LABBE Corentin > wrote: >> of_match_device could return NULL, and so cause a NULL pointer >> dereference later at line 132: >> priv->flags = (uintptr_t) of_id->data; >> >> Reported-by: coverity (CID 1324141) >> Signed-off-by: LABBE Corentin >> --- >> drivers/gpio/gpio-74xx-mmio.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c >> index 6ed7c0f..4a7be0f 100644 >> --- a/drivers/gpio/gpio-74xx-mmio.c >> +++ b/drivers/gpio/gpio-74xx-mmio.c >> @@ -120,6 +120,9 @@ static int mmio_74xx_gpio_probe(struct platform_device *pdev) >> void __iomem *dat; >> int err; >> >> + if (!of_id) >> + return -ENODEV; >> + > > Nit: in that case, could you also move the assignment of of_id to its > own line right above these added lines? It would keep things in the > same place I think it's more that just a nit. +1 to move assignment. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/