Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbbKIO0n (ORCPT ); Mon, 9 Nov 2015 09:26:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47891 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbbKIO0h (ORCPT ); Mon, 9 Nov 2015 09:26:37 -0500 Subject: Re: [PATCH v3 3/3] ibmvscsi: Allow to configure maximum LUN To: Hannes Reinecke , martin.petersen@oracle.com References: <1447077232-5335-1-git-send-email-lvivier@redhat.com> <1447077232-5335-4-git-send-email-lvivier@redhat.com> <5640A7F6.6050201@suse.de> Cc: brking@linux.vnet.ibm.com, tyreld@linux.vnet.ibm.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Laurent Vivier Message-ID: <5640AD1A.70602@redhat.com> Date: Mon, 9 Nov 2015 15:26:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <5640A7F6.6050201@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1186 Lines: 34 On 09/11/2015 15:04, Hannes Reinecke wrote: > On 11/09/2015 02:53 PM, Laurent Vivier wrote: >> QEMU allows until 32 LUNs. >> >> Signed-off-by: Laurent Vivier >> --- >> drivers/scsi/ibmvscsi/ibmvscsi.c | 9 ++++++++- >> drivers/scsi/ibmvscsi/ibmvscsi.h | 1 + >> 2 files changed, 9 insertions(+), 1 deletion(-) >> > Nothing to do with QEMU; this is a driver limitation. > Please fixup the description. Yes, you're right, and I think I didn't define correctly the maximum value, I use 31 instead of 32 as explained in include/scsi/scsi_host.h: /* * These three parameters can be used to allow for wide scsi, * and for host adapters that support multiple busses * The last two should be set to 1 more than the actual max id * or lun (e.g. 8 for SCSI parallel systems). */ unsigned int max_channel; unsigned int max_id; u64 max_lun; Laurent -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/