Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751690AbbKIPfw (ORCPT ); Mon, 9 Nov 2015 10:35:52 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:34760 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbbKIPfv (ORCPT ); Mon, 9 Nov 2015 10:35:51 -0500 MIME-Version: 1.0 In-Reply-To: <1447055848-28180-1-git-send-email-shailendra.v@samung.com> References: <1447055848-28180-1-git-send-email-shailendra.v@samung.com> Date: Tue, 10 Nov 2015 00:35:50 +0900 Message-ID: Subject: Re: [PATCH] arch:arm:mm:Correction in the boundary check for module end address. From: Jungseung Lee To: Shailendra Verma Cc: Russell King , Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Riley Andrews , Laura Abbott , Shailendra Verma , Dan Carpenter , Mitchel Humpherys , Sumit Semwal , "Kirill A. Shutemov" , Gioh Kim , Rasmus Villemoes , Shawn Lin , Markus Elfring , "linux-arm-kernel@lists.infradead.org" , devel@driverdev.osuosl.org, Ravikant Bijendra Sharma , Shailendra Verma , linux-kernel@vger.kernel.org, vidushi.koul@samsung.com, hillf.zj@alibaba-inc.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1453 Lines: 40 Hi, 2015-11-09 16:57 GMT+09:00 Shailendra Verma : > From: Shailendra Verma > > The module end boundary check is not proper.The out of bound value > of module end can produce undesired results. > > Signed-off-by: Shailendra Verma > Reviewed-by: Ravikant Bijendra Sharma > --- > linux-4.3-rc6/arch/arm/mm/pageattr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-4.3-rc6/arch/arm/mm/pageattr.c b/linux-4.3-rc6/arch/arm/mm/pageattr.c > index cf30daf..be7fe4b 100644 > --- a/linux-4.3-rc6/arch/arm/mm/pageattr.c > +++ b/linux-4.3-rc6/arch/arm/mm/pageattr.c > @@ -52,7 +52,7 @@ static int change_memory_common(unsigned long addr, int numpages, > if (start < MODULES_VADDR || start >= MODULES_END) > return -EINVAL; > > - if (end < MODULES_VADDR || start >= MODULES_END) > + if (end < MODULES_VADDR || end >= MODULES_END) > return -EINVAL; > > data.set_mask = set_mask; > -- > 1.7.9.5 > Same patch with proper format is already submitted by Hillf. https://lkml.org/lkml/2015/5/3/202 Best Regards, Jungseung Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/