Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752700AbbKIRL5 (ORCPT ); Mon, 9 Nov 2015 12:11:57 -0500 Received: from mail-bn1on0143.outbound.protection.outlook.com ([157.56.110.143]:35456 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751897AbbKIRLx convert rfc822-to-8bit (ORCPT ); Mon, 9 Nov 2015 12:11:53 -0500 From: Hartley Sweeten To: Ranjith , "gregkh@linuxfoundation.org" CC: "abbotti@mev.co.uk" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] comedi: pcmmio: Fix coding style - use BIT macro Thread-Topic: [PATCH] comedi: pcmmio: Fix coding style - use BIT macro Thread-Index: AQHRGwASNaQU5kq6kkKAAyeXYLyhpZ6T6PEQ Date: Mon, 9 Nov 2015 16:56:29 +0000 Message-ID: References: <1447081749-10472-1-git-send-email-ranjithece24@gmail.com> In-Reply-To: <1447081749-10472-1-git-send-email-ranjithece24@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=HartleyS@visionengravers.com; x-originating-ip: [184.183.19.121] x-microsoft-exchange-diagnostics: 1;BN3PR0101MB1058;5:zL5z/HVxXoZgDZCew5CQdpSOfo7+KIqBdOYm43huHxhyp9K03O2mIG0D27ScTk7UJCOIOFBAizmFrv5h3Af0aMLk/cRANwkCIcWFVJM4EYSoSebxiRzyg5P68ZHvht7TaIDxCedz27YVA/q3ydkThw==;24:n3BDkMdSuPYhUabxfbi2DDGicbbULrdvQb+W8y/ePxGyvH/Ke6pflt5H/7bUzXkZ7cRMJ6wLR8SMKd8He7Iqho0NzJH+khRkv/rSEsJ/Kik=;20:YFopPe9GmB4PCWAuZxzJySKpwjwBqmwiUHIeoF+Zkz9vOUAV50KISPhKvKLcRh6qDKJIO0hC1eZGdLW/HzinBQ== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1058; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(2401047)(8121501046)(5005006)(520078)(3002001)(10201501046);SRVR:BN3PR0101MB1058;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1058; x-forefront-prvs: 0755F54DD9 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377454003)(199003)(189002)(106356001)(77096005)(19580395003)(5007970100001)(54356999)(40100003)(5008740100001)(5001770100001)(122556002)(33656002)(5004730100002)(5001920100001)(101416001)(189998001)(50986999)(97736004)(5002640100001)(10400500002)(76176999)(81156007)(80792005)(5003600100002)(5001960100002)(106116001)(66066001)(105586002)(2950100001)(102836002)(86362001)(87936001)(2900100001)(2501003)(19580405001)(92566002)(74316001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0101MB1058;H:BN3PR0101MB1057.prod.exchangelabs.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2015 16:56:29.7646 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0101MB1058 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 23 On Monday, November 09, 2015 8:09 AM, Ranjith wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith > --- > drivers/staging/comedi/drivers/pcmmio.c | 44 +++++++++++++++---------------- > 1 file changed, 22 insertions(+), 22 deletions(-) > Hello, Again, no problems with the patch but your sign-off needs to include your full legal name. Regards, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/