Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752100AbbKIR2N (ORCPT ); Mon, 9 Nov 2015 12:28:13 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:18516 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980AbbKIR2K (ORCPT ); Mon, 9 Nov 2015 12:28:10 -0500 Date: Mon, 9 Nov 2015 20:27:53 +0300 From: Dan Carpenter To: Ranjith Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, abbotti@mev.co.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] comedi: me_daq: Fix coding style - use BIT macro Message-ID: <20151109172752.GV18797@mwanda> References: <1447089236-14389-1-git-send-email-ranjithece24@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447089236-14389-1-git-send-email-ranjithece24@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 419 Lines: 13 On Mon, Nov 09, 2015 at 10:43:56PM +0530, Ranjith wrote: > +#define ADC_GAIN_2 (BIT(5) & (~BIT(4))) It looks really weird to write it this way... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/