Date: Mon, 09 Nov 2015 13:25:23 -0500 (EST)
Message-Id: <20151109.132523.624907753522887529.davem@davemloft.net>
To: rweikusat@mobileactivedefense.com
Cc: jbaron@akamai.com, dvyukov@google.com, syzkaller@googlegroups.com,
        mkubecek@suse.cz, viro@zeniv.linux.org.uk,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        hannes@stressinduktion.org, dhowells@redhat.com, paul@paul-moore.com,
        salyzyn@android.com, sds@tycho.nsa.gov, ying.xue@windriver.com,
        netdev@vger.kernel.org, kcc@google.com, glider@google.com,
        andreyknvl@google.com, sasha.levin@oracle.com, jln@google.com,
        keescook@google.com, minipli@googlemail.com
Subject: Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue
From: David Miller <davem@davemloft.net>
In-Reply-To: <87fv0fnslr.fsf_-_@doppelsaurus.mobileactivedefense.com>
References: <563CC002.5050307@akamai.com>
	<87ziyrcg67.fsf@doppelsaurus.mobileactivedefense.com>
	<87fv0fnslr.fsf_-_@doppelsaurus.mobileactivedefense.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 712
Lines: 22

From: Rainer Weikusat <rweikusat@mobileactivedefense.com>
Date: Mon, 09 Nov 2015 14:40:48 +0000

> +	__remove_wait_queue(&unix_sk(u->peer_wake.private)->peer_wait,
> +			    &u->peer_wake);

This is more simply:

	__remove_wait_queue(&unix_sk(u->peer_wake.private)->peer_wait, q);

> +static inline int unix_dgram_peer_recv_ready(struct sock *sk,
> +					     struct sock *other)

Please do not us the inline keyword in foo.c files, let the compiler
decide.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/