Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241AbbKISjy (ORCPT ); Mon, 9 Nov 2015 13:39:54 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:54759 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751748AbbKISjw (ORCPT ); Mon, 9 Nov 2015 13:39:52 -0500 From: Punit Agrawal To: Rob Herring Cc: devicetree@vger.kernel.org, viresh.kumar@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, edubezval@gmail.com, dawei.chien@mediatek.com, Mark Rutland Subject: Re: [PATCH v3 1/3] devicetree: bindings: Add optional dynamic-power-coefficient property References: <1447090163-13700-1-git-send-email-punit.agrawal@arm.com> <1447090163-13700-2-git-send-email-punit.agrawal@arm.com> <20151109174542.GA19016@rob-hp-laptop> Date: Mon, 09 Nov 2015 18:39:35 +0000 In-Reply-To: <20151109174542.GA19016@rob-hp-laptop> (Rob Herring's message of "Mon, 9 Nov 2015 11:45:42 -0600") Message-ID: <9hhvb9b6mqg.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3459 Lines: 85 Rob Herring writes: > On Mon, Nov 09, 2015 at 05:29:21PM +0000, Punit Agrawal wrote: >> The dynamic power consumption of a device is proportional to the >> square of voltage (V) and the clock frequency (f). It can be expressed as >> >> Pdyn = dynamic-power-coefficient * V^2 * f. >> >> The coefficient represents the running time dynamic power consumption in >> units of mw/MHz/uVolt^2 and can be used in the above formula to >> calculate the dynamic power in mW. > > I have no issue with the binding, but I wonder if a single value is > really sufficient to model this. Don't you also need a static > component? In general, power consumption does consist of the static and dynamic power. Here we are only modelling the dynamic component. For CPUs, we found that a single-coefficient model using frequency and voltages gives a reasonable estimation of dynamic power consumption. For thermal management, because of using closed loop control providing the dynamic consumption is good enough as long as static power for your platform is not significant. On the other hand, there isn't a generally applicable model for static power - it has complex relationships with temperature, voltages, etc which make it hard to express as a simple formula. For platforms where static power is significant, providing it via platform code is the only option for now. This patchset enables platforms where dynamic power works well to setup their power model for thermal management via device tree. > > Rob > >> >> Signed-off-by: Punit Agrawal >> Cc: Rob Herring >> Cc: Mark Rutland >> --- >> Documentation/devicetree/bindings/arm/cpus.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt >> index 91e6e5c..c33362d 100644 >> --- a/Documentation/devicetree/bindings/arm/cpus.txt >> +++ b/Documentation/devicetree/bindings/arm/cpus.txt >> @@ -240,6 +240,23 @@ nodes to be present and contain the properties described below. >> Definition: Specifies the syscon node controlling the cpu core >> power domains. >> >> + - dynamic-power-coefficient >> + Usage: optional >> + Value type: >> + Definition: A u32 value that represents the running time dynamic >> + power coefficient in units of mW/MHz/uVolt^2. The >> + coefficient can either be calculated from power >> + measurements or derived by analysis. >> + >> + The dynamic power consumption of the CPU is >> + proportional to the square of the Voltage (V) and >> + the clock frequency (f). The coefficient is used to >> + calculate the dynamic power as below - >> + >> + Pdyn = dynamic-power-coefficient * V^2 * f >> + >> + where voltage is in uV, frequency is in MHz. >> + >> Example 1 (dual-cluster big.LITTLE system 32-bit): >> >> cpus { >> -- >> 2.5.3 >> > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/