Date: Mon, 9 Nov 2015 11:17:30 -0800
From: Eduardo Valentin <edubezval@gmail.com>
To: Caesar Wang <wxt@rock-chips.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the thermal-soc tree
Message-ID: <20151109191729.GA10824@localhost.localdomain>
References: <20151105160113.5d6f73f7@canb.auug.org.au>
 <563B2DC8.1080900@rock-chips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <563B2DC8.1080900@rock-chips.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1931
Lines: 62

Stephen,

On Thu, Nov 05, 2015 at 06:22:00PM +0800, Caesar Wang wrote:
> 
> 
> 在 2015年11月05日 13:01, Stephen Rothwell 写道:
> >Hi Eduardo,
> >
> >After merging the thermal-soc tree, today's linux-next build (powerpc
> >allyesconfig) failed like this:
> >
> >drivers/thermal/rockchip_thermal.c: In function 'rockchip_thermal_suspend':
> >drivers/thermal/rockchip_thermal.c:641:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
> >   pinctrl_pm_select_sleep_state(dev);
> >   ^
> >drivers/thermal/rockchip_thermal.c: In function 'rockchip_thermal_resume':
> >drivers/thermal/rockchip_thermal.c:679:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
> >   pinctrl_pm_select_default_state(dev);
> >   ^
> 

Thanks, I wonder why I did not catch this in my bots.

> That's indeed wonder that I build up in next-kernel-v4.3, applied
> into chromium v3.14 stable kernel.
> 
> from the log I guess wee need the include file:
> "#include <linux/pinctrl/consumer.h>"

Caesar, are you sending a patch or should I just take care of it?

BR,

> 
> 
> >
> >Caused by commit
> >
> >   7e38a5b1daa1 ("thermal: rockchip: support the sleep pinctrl state to avoid glitches")
> >
> >Probably just a missing include file.
> >
> >I have reverted that commit for today.
> >
> >
> >
> 
> -- 
> Yours,
> Caesar
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/