Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752059AbbKITSV (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Nov 2015 14:18:21 -0500
Received: from mta02.ornl.gov ([128.219.177.12]:43961 "EHLO mta02.ornl.gov"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751755AbbKITST (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Nov 2015 14:18:19 -0500
X-SG: RELAYLIST
X-IronPort-AV: E=Sophos;i="5.20,266,1444708800"; 
   d="scan'208";a="91867995"
From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Shivani Bhardwaj'" <shivanib134@gmail.com>,
        =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= <kernel@kempniu.pl>
CC: "Drokin, Oleg" <oleg.drokin@intel.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "Dilger, Andreas" <andreas.dilger@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function
Thread-Topic: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function
Thread-Index: AQHRGTCT+YDv51QdFEixzgbhYBGVDJ6UCP8AgAAxzQD//9iYUA==
Date: Mon, 9 Nov 2015 19:18:16 +0000
Message-ID: <434305b1308b4da48f38891867e65120@EXCHCS32.ornl.gov>
References: <cover.1446881645.git.shivanib134@gmail.com>
 <2f66e94923a7655495165123a5efe3bd099d77bc.1446881645.git.shivanib134@gmail.com>
 <20151109133730.GA9390@eudyptula.hq.kempniu.pl>
 <CAKHNQQFbNEhv3CP+GibeM-yu_zX4XgJ_f4QJzJ8Nn_JG--c1FQ@mail.gmail.com>
In-Reply-To: <CAKHNQQFbNEhv3CP+GibeM-yu_zX4XgJ_f4QJzJ8Nn_JG--c1FQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [128.219.12.132]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tA9JIQkZ012114
Content-Length: 728
Lines: 18

>On Mon, Nov 9, 2015 at 7:07 PM, Michał Kępień <kernel@kempniu.pl> wrote:
>>> Remove the function ll_finish_md_op_data() and replace all its calls
>>> with the standrd function ll_finish_md_op_data().
>>
>> I believe you meant to write "standard function kfree()".
>>
>
>Yes. I am so sorry. Should I be sending the whole series again?
>Thank you
>Shivani

Yes please redo the series. I saw Oleg's concern and I would recommend that
besides the conversion to kfree that you add comments about what is being deleted.
I.E

/* Free struct md_op_data  data*/
kfree(...)
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?