Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521AbbKITgs (ORCPT ); Mon, 9 Nov 2015 14:36:48 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:36229 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbbKITgn (ORCPT ); Mon, 9 Nov 2015 14:36:43 -0500 Date: Mon, 9 Nov 2015 11:36:39 -0800 From: Eduardo Valentin To: Caesar Wang Cc: rui.zhang@intel.com, heiko@sntech.de, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org, sfr@canb.auug.org.au, lkp@intel.com Subject: Re: [PATCH] thermal: rockchip: fix compile error Message-ID: <20151109193638.GB10824@localhost.localdomain> References: <1446990043-8096-1-git-send-email-wxt@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446990043-8096-1-git-send-email-wxt@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1830 Lines: 56 On Sun, Nov 08, 2015 at 09:40:43PM +0800, Caesar Wang wrote: > Missing a include file caused compile error. > > drivers/thermal/rockchip_thermal.c: > In function 'rockchip_thermal_suspend': > drivers/thermal/rockchip_thermal.c:720:2: error: implicit > declaration of function 'pinctrl_pm_select_sleep_state' > [-Werror=implicit-function-declaration] > pinctrl_pm_select_sleep_state(dev); > ^ > drivers/thermal/rockchip_thermal.c: > In function 'rockchip_thermal_resume': > drivers/thermal/rockchip_thermal.c:759:2: error: implicit > declaration of function 'pinctrl_pm_select_default_state' > [-Werror=implicit-function-declaration] > ^pinctrl_pm_select_default_state(dev); > cc1: some warnings being treated as errors > > Fixes: 7e38a5b1daa1 ("thermal: rockchip: support the sleep pinctrl state > to avoid glitches") Adding this to my tree and sending to ruis too. Thanks > > Reported-by: Stephen Rothwell > Reported-by: kbuild test robot > Signed-off-by: Caesar Wang > --- > > drivers/thermal/rockchip_thermal.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c > index df28049..8928d67 100644 > --- a/drivers/thermal/rockchip_thermal.c > +++ b/drivers/thermal/rockchip_thermal.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > /** > * If the temperature over a period of time High, > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/