Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752284AbbKITkX (ORCPT ); Mon, 9 Nov 2015 14:40:23 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:33369 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752070AbbKITkS (ORCPT ); Mon, 9 Nov 2015 14:40:18 -0500 Subject: Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to handle large PAT bit To: Toshi Kani , hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com References: <1442514264-12475-1-git-send-email-toshi.kani@hpe.com> <1442514264-12475-5-git-send-email-toshi.kani@hpe.com> <5640E08F.5020206@oracle.com> <1447096601.21443.15.camel@hpe.com> Cc: akpm@linux-foundation.org, bp@alien8.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, jgross@suse.com, konrad.wilk@oracle.com, elliott@hpe.com From: Boris Ostrovsky Message-ID: <5640F673.8070400@oracle.com> Date: Mon, 9 Nov 2015 14:39:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1447096601.21443.15.camel@hpe.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2221 Lines: 61 On 11/09/2015 02:16 PM, Toshi Kani wrote: > On Mon, 2015-11-09 at 13:06 -0500, Boris Ostrovsky wrote: >> On 09/17/2015 02:24 PM, Toshi Kani wrote: >>> Now that we have pud/pmd mask interfaces, which handle pfn & flags >>> mask properly for the large PAT bit. >>> >>> Fix pud/pmd pfn & flags interfaces by replacing PTE_PFN_MASK and >>> PTE_FLAGS_MASK with the pud/pmd mask interfaces. >>> >>> Suggested-by: Juergen Gross >>> Signed-off-by: Toshi Kani >>> Cc: Juergen Gross >>> Cc: Konrad Wilk >>> Cc: Thomas Gleixner >>> Cc: H. Peter Anvin >>> Cc: Ingo Molnar >>> Cc: Borislav Petkov >>> --- >>> arch/x86/include/asm/pgtable.h | 14 ++++++++------ >>> arch/x86/include/asm/pgtable_types.h | 4 ++-- >>> 2 files changed, 10 insertions(+), 8 deletions(-) >>> >> >> Looks like this commit is causing this splat for 32-bit kernels. I am >> attaching my config file, just in case. > Thanks for the report! I'd like to reproduce the issue since I am not sure how > this change caused it... > > I tried to build a kernel with the attached config file, and got the following > error. Not sure what I am missing. > > ---- > $ make -j24 ARCH=i386 > : > LD drivers/built-in.o > LINK vmlinux > ./.config: line 44: $'\r': command not found I wonder whether my email client added ^Ms to the file that I send. It shouldn't have. > Makefile:929: recipe for target 'vmlinux' failed > make: *** [vmlinux] Error 127 > ---- > > Do you have steps to reproduce the issue? Or do you see it during boot-time? This always happens just after system has booted, it may still be going over init scripts. I am booting with ramdisk, don't know whether it has anything to do with this problem. FWIW, it looks like pmd_pfn_mask() inline is causing this. Reverting it alone makes this crash go away. -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/