Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103AbbKIT7F (ORCPT ); Mon, 9 Nov 2015 14:59:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57500 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbbKIT7D (ORCPT ); Mon, 9 Nov 2015 14:59:03 -0500 Date: Mon, 9 Nov 2015 11:59:02 -0800 From: Greg KH To: Julia Lawall , kbuild test robot Cc: Shivani Bhardwaj , kbuild-all@01.org, andreas.dilger@intel.com, oleg.drokin@intel.com, lustre-devel@lists.lustre.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings Message-ID: <20151109195902.GB11820@kroah.com> References: <201511100309.kmJ2bdfD%fengguang.wu@intel.com> <20151109194350.GA117144@cairo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151109194350.GA117144@cairo> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1539 Lines: 44 On Tue, Nov 10, 2015 at 03:43:50AM +0800, kbuild test robot wrote: > drivers/staging/lustre/lustre/llite/xattr.c:199:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Shivani Bhardwaj > Signed-off-by: Fengguang Wu > --- > > xattr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/drivers/staging/lustre/lustre/llite/xattr.c > +++ b/drivers/staging/lustre/lustre/llite/xattr.c > @@ -192,11 +192,10 @@ int ll_setxattr_common(struct inode *ino > valid, name, pv, size, 0, flags, > ll_i2suppgid(inode), &req); > #ifdef CONFIG_FS_POSIX_ACL > - if (new_value != NULL) > /* > * Release the posix ACL space. > */ > - kfree(new_value); > + kfree(new_value); Looks like a bug in coccinelle, the comment line should also be indented to the left. Julia, any ideas? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/