Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbbKIUAc (ORCPT ); Mon, 9 Nov 2015 15:00:32 -0500 Received: from mail-io0-f176.google.com ([209.85.223.176]:33146 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbbKIUAa (ORCPT ); Mon, 9 Nov 2015 15:00:30 -0500 MIME-Version: 1.0 In-Reply-To: <5640E135.2020007@linaro.org> References: <1446874577-14539-1-git-send-email-yang.shi@linaro.org> <20151108022726.GB39441@ast-mbp.thefacebook.com> <5640E135.2020007@linaro.org> Date: Mon, 9 Nov 2015 12:00:29 -0800 Message-ID: Subject: Re: [PATCH] arm64: bpf: fix JIT stack setup From: Z Lim To: "Shi, Yang" Cc: Alexei Starovoitov , Catalin Marinas , Will Deacon , Alexei Starovoitov , daniel@iogearbox.net, Xi Wang , LKML , Network Development , "linux-arm-kernel@lists.infradead.org" , linaro-kernel@lists.linaro.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 958 Lines: 27 On Mon, Nov 9, 2015 at 10:08 AM, Shi, Yang wrote: > I added it to stay align with ARMv8 AAPCS to maintain the correct FP during > function call. It makes us get correct stack backtrace. > > I think we'd better to keep compliant with ARMv8 AAPCS in BPF JIT prologue > too. > > If nobody thinks it is necessary, we definitely could remove that change. Oh no, I don't think anyone will say it's unnecessary! I agree the A64_FP-related change is a good idea, so stack unwinding works. How about splitting this into two patches? One for the BPF-related bug, and another for A64 FP-handling. Thanks again for tracking this down and improving things overall for arm64 :) > > Thanks, > Yang > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/