Date: Mon, 9 Nov 2015 15:32:16 -0700
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jeremiah Mahler <jmmahler@gmail.com>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        peterhuewe@gmx.de, gregkh@linuxfoundation.org, dhowells@redhat.com,
        artem.bityutskiy@linux.intel.com, Tejun Heo <tj@kernel.org>,
        NeilBrown <neilb@suse.de>, Guenter Roeck <linux@roeck-us.net>,
        "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 03/10] sysfs: added
 __compat_only_sysfs_link_entry_to_kobj()
Message-ID: <20151109223216.GA1305@obsidianresearch.com>
References: <1445020843-9382-1-git-send-email-jarkko.sakkinen@linux.intel.com>
 <1445020843-9382-4-git-send-email-jarkko.sakkinen@linux.intel.com>
 <20151107002356.GA6026@newt.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151107002356.GA6026@newt.localdomain>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 911
Lines: 20

On Fri, Nov 06, 2015 at 04:23:56PM -0800, Jeremiah Mahler wrote:
> On Fri, Oct 16, 2015 at 09:40:22PM +0300, Jarkko Sakkinen wrote:
> > Added a new function __compat_only_sysfs_link_group_to_kobj() that adds
> > a symlink from attribute or group to a kobject. This needed for
> > maintaining backwards compatibility with PPI attributes in the TPM
> > driver.

> One problem with this patch is that it adds a bunch of code but none of
> it is used.  So if there is a bug, git bisect will point to a later
> patch instead of this one.

It is fairly standard practice to split cross-subsystem patches like
this, it aids review. git bisect is not a perfect tool.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/