Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752116AbbKIXZs (ORCPT ); Mon, 9 Nov 2015 18:25:48 -0500 Received: from mga14.intel.com ([192.55.52.115]:23818 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbbKIXZq (ORCPT ); Mon, 9 Nov 2015 18:25:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,267,1444719600"; d="scan'208";a="846510433" From: "Luck, Tony" To: "Rafael J. Wysocki" , Tetsuo Handa CC: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , Russell King , "linux-acpi@vger.kernel.org" , "drbd-user@lists.linbit.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Drokin, Oleg" , "Dilger, Andreas" , "codalist@coda.cs.cmu.edu" , "linux-mtd@lists.infradead.org" , Jan Kara , "linux-fsdevel@vger.kernel.org" , "netdev@vger.kernel.org" , Boris Petkov Subject: RE: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() Thread-Topic: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() Thread-Index: AQHRGzmklP8AvyaIgkWU5IaAF+WEeJ6UVLvQ Date: Mon, 9 Nov 2015 23:25:44 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F32B83DE2@ORSMSX114.amr.corp.intel.com> References: <1447070170-8512-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <5253459.IxnqkcU2vL@vostro.rjw.lan> In-Reply-To: <5253459.IxnqkcU2vL@vostro.rjw.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tA9NPqW1013081 Content-Length: 500 Lines: 10 > ACK for the ACPI changes (and CCing Tony and Boris for the heads-up as they > are way more famailiar with the APEI code than I am). Sure. If kvfree() really is smart enough to figure it out then there it no point in the if (blah) kfree() else vfree(). The drivers/acpi/apei/erst.c code isn't doing anything subtle or magic here. -Tony ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?