Date: Mon, 9 Nov 2015 16:19:16 -0800
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>, Paul Turner <pjt@google.com>,
        Len Brown <len.brown@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Andi Kleen <andi.kleen@intel.com>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>
Subject: Re: [RFC PATCH 3/3] sched: introduce synchronized idle injection
Message-ID: <20151109161916.1400a0b4@icelake>
In-Reply-To: <20151106154929.39aa6701@icelake>
References: <1446509428-5616-1-git-send-email-jacob.jun.pan@linux.intel.com>
	<1446509428-5616-4-git-send-email-jacob.jun.pan@linux.intel.com>
	<20151103133120.GD17308@twins.programming.kicks-ass.net>
	<20151105135952.GE11639@twins.programming.kicks-ass.net>
	<20151105153625.25fbfe69@icelake>
	<20151106074510.GM3604@twins.programming.kicks-ass.net>
	<20151106154929.39aa6701@icelake>
Organization: OTC
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1141
Lines: 26

On Fri, 6 Nov 2015 15:49:29 -0800
Jacob Pan <jacob.jun.pan@linux.intel.com> wrote:

> > Check the softirq stuff before calling throttle ?  
> 
> yes, played with it but it seems there are other cases causing pending
> softirq in idle in addition to throttle. I still haven't figure it
> out, this problem only shows up in heavy irq, network load. e.g.
> compile kernel over NFS. Debugging.
ok, I added a check for softirq_pending and a retry. seems to work. Now
idle injection will allow softirq and softirqd to run. The caveat is
that during that injection period, if softirqd does not run for the
entire duration, other normal tasks would also run during forced idle.
But just for that period. I guess we have to strike for the right
balance for QoS and overhead. For most workload, pending softirq is
rare so the tasks slip under softirqd are also rare. Will send out V2
soon.

Thanks,

Jacob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/