Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbbKJAoz (ORCPT ); Mon, 9 Nov 2015 19:44:55 -0500 Received: from mta02.ornl.gov ([128.219.177.12]:35829 "EHLO mta02.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbbKJAov convert rfc822-to-8bit (ORCPT ); Mon, 9 Nov 2015 19:44:51 -0500 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.20,267,1444708800"; d="scan'208";a="91889044" From: "Simmons, James A." To: "'Drokin, Oleg'" , James Simmons CC: "" , "Greg Kroah-Hartman" , Linux Kernel Mailing List , "" Subject: RE: [lustre-devel] [PATCH] staging: lustre: export cfs_str2mask Thread-Topic: [lustre-devel] [PATCH] staging: lustre: export cfs_str2mask Thread-Index: AQHRGkN29O5e/ZW6r06IQLd1ZWDTeJ6UD5KAgABdNkA= Date: Tue, 10 Nov 2015 00:44:48 +0000 Message-ID: References: <1447000500-29427-1-git-send-email-jsimmons@infradead.org> <1447000500-29427-6-git-send-email-jsimmons@infradead.org> <5F41E759-F653-4A35-B2E5-15544BCF4BD2@intel.com> In-Reply-To: <5F41E759-F653-4A35-B2E5-15544BCF4BD2@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1327 Lines: 29 >> We need cfs_str2mask exported for our server code. >> Even with the server code not available upstream >> it would be nice to use the upstream code on Lustre >> servers. >> >> Signed-off-by: James Simmons >> --- >> .../staging/lustre/lustre/libcfs/libcfs_string.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c >> index d40be53..05630f8 100644 >> --- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c >> +++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c >> @@ -111,6 +111,7 @@ int cfs_str2mask(const char *str, const char *(*bit2str)(int bit), >> *oldmask = newmask; >> return 0; >> } >> +EXPORT_SYMBOL(cfs_str2mask); > >If this is the case of it being used out of tree, I suspect a comment here to that effect would be >useful, otherwise next person running a script to eliminate unused EXPORT_SYMBOLs would kill it again. I will send another patch with comments not to remove the new code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/