Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751740AbbKJC4m (ORCPT ); Mon, 9 Nov 2015 21:56:42 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:32922 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751035AbbKJC4k (ORCPT ); Mon, 9 Nov 2015 21:56:40 -0500 MIME-Version: 1.0 In-Reply-To: <20150717054643.GA7209@vaishali-Ideapad-Z570> References: <20150717054643.GA7209@vaishali-Ideapad-Z570> Date: Tue, 10 Nov 2015 08:26:38 +0530 Message-ID: Subject: Re: [PATCH] wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE From: Vaishali Thakkar To: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1760 Lines: 61 On Fri, Jul 17, 2015 at 11:16 AM, Vaishali Thakkar wrote: > Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use > struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with > the goal of getting rid of this macro completely. > > The Coccinelle semantic patch that performs this transformation > is as follows: > > @@ > identifier a; > declarer name DEFINE_PCI_DEVICE_TABLE; > initializer i; > @@ > - DEFINE_PCI_DEVICE_TABLE(a) > + const struct pci_device_id a[] > = i; > > Signed-off-by: Vaishali Thakkar > --- > This patch is against linux-next branch > --- > drivers/scsi/wd719x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c > index 61346aa..4655d16 100644 > --- a/drivers/scsi/wd719x.c > +++ b/drivers/scsi/wd719x.c > @@ -962,7 +962,7 @@ static void wd719x_pci_remove(struct pci_dev *pdev) > scsi_host_put(sh); > } > > -static DEFINE_PCI_DEVICE_TABLE(wd719x_pci_table) = { > +static const struct pci_device_id wd719x_pci_table[] = { > { PCI_DEVICE(PCI_VENDOR_ID_WD, 0x3296) }, > {} > }; > -- > 1.9.1 > Hi James, Can you please apply this patch? Actually this is the only case which is using DEFINE_PCI_DEVICE_TABLE in the kernel and the use is blocking the removal of everything related to this macro in the kernel. So, it would be good if you can apply this patch. Inform me if it's not in your queue and I need to resend it. Thanks -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/