Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751616AbbKJDVW (ORCPT ); Mon, 9 Nov 2015 22:21:22 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52772 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbbKJDVU (ORCPT ); Mon, 9 Nov 2015 22:21:20 -0500 Subject: Re: [PATCH V2 2/3] scsi: fix compiler warning for sg To: Andy Shevchenko References: <1447034266-28003-1-git-send-email-okaya@codeaurora.org> <1447034266-28003-3-git-send-email-okaya@codeaurora.org> Cc: linux-scsi , timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, Andy Gross , linux-arm-msm@vger.kernel.org, linux-arm Mailing List , Doug Gilbert , "James E.J. Bottomley" , "linux-kernel@vger.kernel.org" From: Sinan Kaya Message-ID: <564162AB.6080803@codeaurora.org> Date: Mon, 9 Nov 2015 22:21:15 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 30 On 11/9/2015 9:14 AM, Andy Shevchenko wrote: > Parens are useless, noticed later, sorry. > > Isn't mult_frac() enough here? > > Btw, can you mention explicitly what is the warning you get > (copy'n'paste of the line would be okay)? I created this patch back in March with an older version of the compiler and older kernel (3.19). I'm no longer able to reproduce this with this compiler and linux-next. Thread model: posix gcc version 4.8.3 20140401 (prerelease) (crosstool-NG linaro-1.13.1-4.8-2014.04 - Linaro GCC 4.8-2014.04) I'll drop this patch. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/