Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280AbbKJExX (ORCPT ); Mon, 9 Nov 2015 23:53:23 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:56255 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbbKJExV (ORCPT ); Mon, 9 Nov 2015 23:53:21 -0500 Subject: Re: [PATCH V2 2/3] scsi: fix compiler warning for sg To: Sinan Kaya , Andy Shevchenko Cc: linux-scsi , cov@codeaurora.org, jcm@redhat.com, Andy Gross , linux-arm-msm@vger.kernel.org, linux-arm Mailing List , Doug Gilbert , "James E.J. Bottomley" , "linux-kernel@vger.kernel.org" References: <1447034266-28003-1-git-send-email-okaya@codeaurora.org> <1447034266-28003-3-git-send-email-okaya@codeaurora.org> <564162AB.6080803@codeaurora.org> <564163F7.2020109@codeaurora.org> <564177D7.7070103@codeaurora.org> From: Timur Tabi Message-ID: <5641783D.3030108@codeaurora.org> Date: Mon, 9 Nov 2015 22:53:17 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:41.0) Gecko/20100101 Firefox/41.0 SeaMonkey/2.38 MIME-Version: 1.0 In-Reply-To: <564177D7.7070103@codeaurora.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 779 Lines: 20 Sinan Kaya wrote: > > The code says it is using these macros for small integers only which > can't overflow. I was trying to get rid of compiler warning and it seems > to have disappeared. I would double-check the assembly code, if I were you. I don't like it when warnings just go away like that. Besides, we *should* be using do_div() for 64-bit division. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/