Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752446AbbKJE5k (ORCPT ); Mon, 9 Nov 2015 23:57:40 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:56632 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbbKJE5i (ORCPT ); Mon, 9 Nov 2015 23:57:38 -0500 Subject: Re: [PATCH V3 2/4] dma: add Qualcomm Technologies HIDMA management driver To: Rob Herring References: <1446958380-23298-1-git-send-email-okaya@codeaurora.org> <1446958380-23298-3-git-send-email-okaya@codeaurora.org> <563ED8DF.6090307@codeaurora.org> <56400230.8030303@codeaurora.org> <20151109182514.GA10896@rob-hp-laptop> Cc: Timur Tabi , dmaengine@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Vinod Koul , Dan Williams , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: <5641793B.6050902@codeaurora.org> Date: Mon, 9 Nov 2015 23:57:31 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151109182514.GA10896@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2112 Lines: 65 On 11/9/2015 1:25 PM, Rob Herring wrote: > On Sun, Nov 08, 2015 at 09:17:20PM -0500, Sinan Kaya wrote: >> On 11/8/2015 12:08 AM, Timur Tabi wrote: >> >> On 11/8/2015 12:08 AM, Timur Tabi wrote: >>> Sinan Kaya wrote: >>>> + val = val & ~(MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS); >>>> + val = val | (mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS); >>>> + val = val & ~(MAX_BUS_REQ_LEN_MASK); >>>> + val = val | (mgmtdev->max_read_request); >>> >>> val &= ~MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS; >>> val |= mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS; >>> val &= ~MAX_BUS_REQ_LEN_MASK; >>> val |= mgmtdev->max_read_request; >>> >>>> +static const struct of_device_id hidma_mgmt_match[] = { >>>> + { .compatible = "qcom,hidma-mgmt", }, >>>> + { .compatible = "qcom,hidma-mgmt-1.0", }, >>>> + { .compatible = "qcom,hidma-mgmt-1.1", }, >>>> + {}, >>>> +}; >>> >>> I thought Rob said that he did NOT want to use version numbers in >>> compatible strings. And what's the difference between these three >>> versions anyway? >>> >> >> This was already discussed here. >> >> https://lkml.org/lkml/2015/11/2/689 >> >> The agreement was to use > > The suggestion... > >> compatible = "qcom,hidma-mgmt-1.1", "qcom,hidma-mgmt-1.0", >> "qcom,hidma-mgmt"; > > I don't really want to see 3 generic-ish strings. > >> I'll be adding code for v1.1 specifically in the future. > > Please drop "qcom,hidma-mgmt" altogether. It is already meaningless. > Then add the 1.1 compatible when you add the code for it. Hopefully you > all can decide on part number(s) by then. > > Rob > OK. I'll only have "qcom,hidma-mgmt-1.0" for now. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/