Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751616AbbKJHQX (ORCPT ); Tue, 10 Nov 2015 02:16:23 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:33194 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbbKJHQQ (ORCPT ); Tue, 10 Nov 2015 02:16:16 -0500 Date: Tue, 10 Nov 2015 08:16:11 +0100 From: LABBE Corentin To: Andy Shevchenko Cc: Alexandre Courbot , Linus Walleij , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH] gpio: 74xx: fix a possible NULL dereference Message-ID: <20151110071611.GA21382@Red> References: <1446738939-22320-1-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 44 On Mon, Nov 09, 2015 at 04:16:16PM +0200, Andy Shevchenko wrote: > On Mon, Nov 9, 2015 at 2:21 AM, Alexandre Courbot wrote: > > On Fri, Nov 6, 2015 at 12:55 AM, LABBE Corentin > > wrote: > >> of_match_device could return NULL, and so cause a NULL pointer > >> dereference later at line 132: > >> priv->flags = (uintptr_t) of_id->data; > >> > >> Reported-by: coverity (CID 1324141) > >> Signed-off-by: LABBE Corentin > >> --- > >> drivers/gpio/gpio-74xx-mmio.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c > >> index 6ed7c0f..4a7be0f 100644 > >> --- a/drivers/gpio/gpio-74xx-mmio.c > >> +++ b/drivers/gpio/gpio-74xx-mmio.c > >> @@ -120,6 +120,9 @@ static int mmio_74xx_gpio_probe(struct platform_device *pdev) > >> void __iomem *dat; > >> int err; > >> > >> + if (!of_id) > >> + return -ENODEV; > >> + > > > > Nit: in that case, could you also move the assignment of of_id to its > > own line right above these added lines? It would keep things in the > > same place > > I think it's more that just a nit. +1 to move assignment. Hello I agree, I will send an updated patch soon. Regards LABBE Corentin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/