Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751417AbbKJHgx (ORCPT ); Tue, 10 Nov 2015 02:36:53 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:48946 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbbKJHgw (ORCPT ); Tue, 10 Nov 2015 02:36:52 -0500 Date: Tue, 10 Nov 2015 08:36:47 +0100 From: Sascha Hauer To: Frank Rowand Cc: Liam Girdwood , Mark Brown , Linux Kernel list Subject: Re: regulator: build warning in regulator_lock_supply() Message-ID: <20151110073647.GB8526@pengutronix.de> References: <564162CC.5080609@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <564162CC.5080609@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:34:57 up 23 days, 16:13, 55 users, load average: 0.01, 0.09, 0.09 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2315 Lines: 65 On Mon, Nov 09, 2015 at 07:21:48PM -0800, Frank Rowand wrote: > In the current Linus tree, new build warning. > > When CONFIG_DEBUG_LOCK_ALLOC is not enabled, > > drivers/regulator/core.c: In function 'regulator_lock_supply': > drivers/regulator/core.c:142:6: warning: unused variable 'i' [-Wunused-variable] > > > Introduced by commit > > 9f01cd4a915e1 ("regulator: core: introduce function to lock regulators and its supplies") We could fix this with the following patch. On the other hand I'd say that it's not our fault that mutex_lock_nested() doesn't use the variable, so maybe it should rather be a static inline function instead of a define? Sascha ---------------------------------8<------------------------------- >From cacf0a5ae54b5255dfd895d32e74611c6cbeee3f Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Tue, 10 Nov 2015 08:32:46 +0100 Subject: [PATCH] regulator: core: Fix unused variable warning When CONFIG_DEBUG_LOCK_ALLOC is not enabled, we get: drivers/regulator/core.c: In function 'regulator_lock_supply': drivers/regulator/core.c:142:6: warning: unused variable 'i' [-Wunused-variable] Fix this by adding a __maybe_unused annotation. Signed-off-by: Sascha Hauer --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 73b7683..2453bce 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -139,7 +139,7 @@ static bool have_full_constraints(void) static void regulator_lock_supply(struct regulator_dev *rdev) { struct regulator *supply; - int i = 0; + int __maybe_unused i = 0; while (1) { mutex_lock_nested(&rdev->mutex, i++); -- 2.6.1 -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/