Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbbKJIP7 (ORCPT ); Tue, 10 Nov 2015 03:15:59 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38095 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbbKJIP5 (ORCPT ); Tue, 10 Nov 2015 03:15:57 -0500 Subject: Re: [RFC PATCH 4/5] samples: livepatch: init reloc list and mark as klp module To: Jessica Yu , Rusty Russell , Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Miroslav Benes References: <1447130755-17383-1-git-send-email-jeyu@redhat.com> <1447130755-17383-5-git-send-email-jeyu@redhat.com> Cc: linux-api@vger.kernel.org, live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org From: Jiri Slaby Message-ID: <5641A7BA.8000100@suse.cz> Date: Tue, 10 Nov 2015 09:15:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447130755-17383-5-git-send-email-jeyu@redhat.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 33 On 11/10/2015, 05:45 AM, Jessica Yu wrote: > Intialize the list of relocation sections in the sample > klp_object (even if the list will be empty in this case). > Also mark module as a livepatch module so that the module > loader can appropriately initialize it. > > Signed-off-by: Jessica Yu > --- > samples/livepatch/livepatch-sample.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c > index fb8c861..2ef9345 100644 > --- a/samples/livepatch/livepatch-sample.c > +++ b/samples/livepatch/livepatch-sample.c > @@ -57,6 +57,7 @@ static struct klp_object objs[] = { > { > /* name being NULL means vmlinux */ > .funcs = funcs, > + .reloc_secs = LIST_HEAD_INIT(objs[0].reloc_secs) And I see now. This is not the best place for it though. I would put INIT_LIST_HEAD in the core code instead. thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/