Subject: Re: [PATCH] mm/mlock.c: drop unneeded initialization in
 munlock_vma_pages_range()
To: Alexey Klimov <klimov.linux@gmail.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
References: <1447114962-31834-1-git-send-email-klimov.linux@gmail.com>
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
        emunson@akamai.com
From: Vlastimil Babka <vbabka@suse.cz>
Message-ID: <5641B864.2020709@suse.cz>
Date: Tue, 10 Nov 2015 10:27:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1447114962-31834-1-git-send-email-klimov.linux@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1034
Lines: 33

On 11/10/2015 01:22 AM, Alexey Klimov wrote:
> Before usage page pointer initialized by NULL is reinitialized by
> follow_page_mask(). Drop useless init of page pointer in the beginning
> of loop.
>
> Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>   mm/mlock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mlock.c b/mm/mlock.c
> index 339d9e0..9cb87cb 100644
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -425,7 +425,7 @@ void munlock_vma_pages_range(struct vm_area_struct *vma,
>   	vma->vm_flags &= VM_LOCKED_CLEAR_MASK;
>
>   	while (start < end) {
> -		struct page *page = NULL;
> +		struct page *page;
>   		unsigned int page_mask;
>   		unsigned long page_increm;
>   		struct pagevec pvec;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/