Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbbKJJ6Z (ORCPT ); Tue, 10 Nov 2015 04:58:25 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:10345 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbbKJJ5m (ORCPT ); Tue, 10 Nov 2015 04:57:42 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 10 Nov 2015 01:55:28 -0800 Subject: Re: [PATCH V2 4/6] dmaengine: tegra-apb: Only save channel state for those in use To: Andy Shevchenko References: <1447075429-27311-1-git-send-email-jonathanh@nvidia.com> <1447075429-27311-5-git-send-email-jonathanh@nvidia.com> CC: Laxman Dewangan , Vinod Koul , Stephen Warren , Thierry Reding , Alexandre Courbot , dmaengine , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Jon Hunter Message-ID: <5641BF8F.1010304@nvidia.com> Date: Tue, 10 Nov 2015 09:57:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.21.132.108] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 31 On 09/11/15 13:58, Andy Shevchenko wrote: > On Mon, Nov 9, 2015 at 3:23 PM, Jon Hunter wrote: >> Currently the tegra-apb DMA driver suspend/resume helpers, save and >> restore the registers for all channels regardless of whether they are >> in use or not. Change this so that only channels that have been >> allocated and configured are saved and restored. > > Nitpick > >> + /* >> + * Only save the state of DMA channels that are in use. >> + */ > > One line? > >> + /* >> + * Only restore the state of DMA channels that are in use. >> + */ > > Same. Ok. Jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/