Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752187AbbKJKHb (ORCPT ); Tue, 10 Nov 2015 05:07:31 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:44201 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbbKJKH2 (ORCPT ); Tue, 10 Nov 2015 05:07:28 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <2d44866ff89480a28c1cf83df864d0da> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: vop: fix window origin calculation To: Mark Yao , David Airlie , Heiko Stuebner , Russell King , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> From: Yakir Yang Message-ID: <5641C1D4.8060006@rock-chips.com> Date: Tue, 10 Nov 2015 18:07:16 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1467 Lines: 43 Hi Mark, On 11/10/2015 05:59 PM, Mark Yao wrote: > From: Dominik Behr > > VOP_WINx_DSP_ST does not require subtracting 1 from the values written to > it. It actually causes the screen to be shifted by one pixel. > > Signed-off-by: Mark Yao I have meet the screen shift problem on RK3036 SDK board, and this could fix my problem, so Tested-by: Yakir Yang - Yakir > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 48719df..4730ae4 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -959,8 +959,8 @@ static int vop_update_plane_event(struct drm_plane *plane, > val = (dest.y2 - dest.y1 - 1) << 16; > val |= (dest.x2 - dest.x1 - 1) & 0xffff; > VOP_WIN_SET(vop, win, dsp_info, val); > - val = (dsp_sty - 1) << 16; > - val |= (dsp_stx - 1) & 0xffff; > + val = dsp_sty << 16; > + val |= dsp_stx & 0xffff; > VOP_WIN_SET(vop, win, dsp_st, val); > VOP_WIN_SET(vop, win, rb_swap, rb_swap); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/