Date: Tue, 10 Nov 2015 10:37:52 +0000
From: Catalin Marinas <catalin.marinas@arm.com>
To: Yang Shi <yang.shi@linaro.org>
Cc: will.deacon@arm.com, mark.rutland@arm.com, linaro-kernel@lists.linaro.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option
 and force to select it
Message-ID: <20151110103752.GH21606@e104818-lin.cambridge.arm.com>
References: <1447092595-12644-1-git-send-email-yang.shi@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447092595-12644-1-git-send-email-yang.shi@linaro.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1038
Lines: 27

On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote:
> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine
> it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory
> is never used.

That's not true since the arm64 definition seems to take precedence.

> This adds a dependency on DEBUG_KERNEL for building with frame pointers.

It doesn't because arm64 selects ARCH_WANT_FRAME_POINTERS.

> ARM64 depends on frame pointer to get correct stack backtrace and need
> FRAME_POINTER kconfig option enabled all the time.
> However, currect implementation makes it could be disabled, so force it
> to be selected by ARM64.
> 
> Signed-off-by: Yang Shi <yang.shi@linaro.org>

Patch applied but I changed the commit log slightly. Thanks.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/