Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbbKJLx7 (ORCPT ); Tue, 10 Nov 2015 06:53:59 -0500 Received: from foss.arm.com ([217.140.101.70]:55498 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338AbbKJLx6 (ORCPT ); Tue, 10 Nov 2015 06:53:58 -0500 Date: Tue, 10 Nov 2015 11:54:00 +0000 From: Will Deacon To: yalin wang Cc: Catalin Marinas , Mark Rutland , Yang Shi , linaro-kernel@lists.linaro.org, LKML , linux-arm-kernel@lists.infradead.org Subject: Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it Message-ID: <20151110115359.GE31947@arm.com> References: <1447092595-12644-1-git-send-email-yang.shi@linaro.org> <20151110103752.GH21606@e104818-lin.cambridge.arm.com> <49B0431C-4FDA-45CB-82AF-FA010197118D@gmail.com> <20151110113505.GI21606@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 36 On Tue, Nov 10, 2015 at 07:43:35PM +0800, yalin wang wrote: > > On Nov 10, 2015, at 19:35, Catalin Marinas wrote: > > On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote: > >> i have a question, > >> why FRAME_POINTER config must be enabled ? > >> and i see ARM arch can disable this config . > >> if i don’t need stack trace dump and the software release is for > >> final product , don’t need debug stack trace log . > >> is it possible to disable it for performance reason ? > > > > If you don't need any stack trace, perf etc., in theory you can disable > > the option. However, the aarch64 gcc compiler always generates it (I'm > > not sure whether the AAPCS mandates it). Anyway, the performance impact > > is very small since there are more general purpose registers available > > in AArch64 already. > > > i just make a test with -fomit-frame-pointer, seems gcc can generate code > without frame pointer, Building without frame-pointers *severely* limits our ability (as open-source developers) to debug problems that we are unable to reproduce locally. Given the lack of widely available hardware compared to the number of platforms in development, I'm strongly opposed to offering this as a supported option for mainline kernels without a compelling performance argument. We have a significant number of general-purpose registers available on arm64, so I would expect the omission of a framepointer to have a somewhat limited impact on performance. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/