Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752233AbbKJMaI (ORCPT ); Tue, 10 Nov 2015 07:30:08 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35896 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbbKJMaF (ORCPT ); Tue, 10 Nov 2015 07:30:05 -0500 Date: Tue, 10 Nov 2015 13:30:00 +0100 From: Ingo Molnar To: Borislav Petkov Cc: X86 ML , LKML , Peter Zijlstra , Andy Lutomirski , Herbert Xu , Matt Mackall , Chris Mason , Josef Bacik , David Sterba Subject: Re: [RFC PATCH 3/3] x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros Message-ID: <20151110123000.GA20227@gmail.com> References: <1447156122-9379-1-git-send-email-bp@alien8.de> <1447156122-9379-4-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447156122-9379-4-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1156 Lines: 38 * Borislav Petkov wrote: > From: Borislav Petkov > > Those are stupid and code should use static_cpu_has_safe() anyway. Kill > the least used and unused ones. So cpufeature.h doesn't really do a good job of explaining what the difference is between all these variants: cpu_has() static_cpu_has() static_cpu_has_safe() it has this comment: /* * Static testing of CPU features. Used the same as boot_cpu_has(). * These are only valid after alternatives have run, but will statically * patch the target code for additional performance. */ The second sentence does not parse. Why does the third sentence have a 'but' for listing properties? It's either bad grammer or tries to tell something that isn't being told properly. It's entirely silent on the difference between static_cpu_has() and static_cpu_has_safe() - what makes the second one 'safe'? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/