From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
        xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
        Ian.Campbell@citrix.com
Subject: Re: [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall
Date: Tue, 10 Nov 2015 13:39:44 +0100
Message-ID: <4039287.QS1nrAMb0E@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1447156675-7418-7-git-send-email-stefano.stabellini@eu.citrix.com>
References: <alpine.DEB.2.02.1511101131350.5676@kaball.uk.xensource.com> <1447156675-7418-7-git-send-email-stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 894
Lines: 25

On Tuesday 10 November 2015 11:57:55 Stefano Stabellini wrote:
> +       op.u.settime64.nsecs = now.tv_nsec;
> +       op.u.settime64.system_time = arch_timer_read_counter() * (u64)NSEC_PER_SEC;
> +       do_div(op.u.settime64.system_time, arch_timer_get_rate());

NSEC_PER_SEC is a large number, doesn't that multiplication overflow the
64-bit system_time variable?

> +       printk("GTOD: Setting to %llu.%u at %llu\n",

				   %llu.%09u

so you get the leading zeroes.

> +              op.u.settime64.secs,
> +              op.u.settime64.nsecs,
> +              op.u.settime64.system_time);
> +       (void)HYPERVISOR_platform_op(&op);

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/