Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752834AbbKJMqB (ORCPT ); Tue, 10 Nov 2015 07:46:01 -0500 Received: from mail.us.es ([193.147.175.20]:44430 "EHLO salida-rhel7.int" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752569AbbKJMp7 (ORCPT ); Tue, 10 Nov 2015 07:45:59 -0500 Date: Tue, 10 Nov 2015 13:45:53 +0100 From: Pablo Neira Ayuso To: Dmitry Safonov <0x7f454c46@gmail.com> Cc: Patrick McHardy , kadlec@blackhole.kfki.hu, davem@davemloft.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: netfilter: fix GCC uninitialized warning Message-ID: <20151110124553.GA22692@salvia> References: <1446835694-6967-1-git-send-email-0x7f454c46@gmail.com> <20151106191008.GA2362@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 20 On Fri, Nov 06, 2015 at 10:13:16PM +0300, Dmitry Safonov wrote: > I thought, it was decided to use 0/NULL/whatever, than uninitialized_var()? > Is right now? > http://thread.gmane.org/gmane.linux.kernel/1383415 I overlook that one. We should stick to mainstream policies as much as possible. Arnd just sent a patch to address one of this by initializing the variable: http://patchwork.ozlabs.org/patch/542259/ Please follow up with a patch to initialize the variable to avoid the warning in other spots. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/