From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Mason <slash.tmp@free.fr>, Mans Rullgard <mans@mansr.com>,
        Andrew Lunn <andrew@lunn.ch>, Ulf Hansson <ulf.hansson@linaro.org>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Javier Martinez Canillas <javier@dowhile0.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Grafting old platform drivers onto a new DT kernel
Date: Tue, 10 Nov 2015 13:56:51 +0100
Message-ID: <5369244.M0xZ8N1mEo@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <5641E6C0.8090507@free.fr>
References: <563B3749.50701@free.fr> <yw1xh9kv5c60.fsf@unicorn.mansr.com> <5641E6C0.8090507@free.fr>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="iso-8859-1"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1064
Lines: 30

On Tuesday 10 November 2015 13:44:48 Mason wrote:
> On 09/11/2015 18:13, M?ns Rullg?rd wrote:
> 
> > Add something like this:
> > 
> > static const struct of_device_id tangox_sdio_dt_ids[] = {
> >       { .compatible = "sigma,tangox-sdio" },
> >       { }
> > };
> > 
> > static struct platform_driver tangox_platform_sdio0 = {
> >       .probe          = sdhci_tangox_probe,
> 
> It looks like one side effect of this transformation is that
> the probe function cannot be __init anymore? Is that correct?
> 
> For this one particular driver, it weighs 944 bytes. (I guess
> a few kilobytes wasted is no big deal...)

Strictly speaking, it was already broken before. You can
detach and reattach a device from a driver through sysfs,
and that will call the probe function again, so it cannot
be marked as __init.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/