Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752711AbbKJNEb (ORCPT ); Tue, 10 Nov 2015 08:04:31 -0500 Received: from mail-yk0-f177.google.com ([209.85.160.177]:34334 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbbKJNE3 (ORCPT ); Tue, 10 Nov 2015 08:04:29 -0500 MIME-Version: 1.0 In-Reply-To: <36DF59CE26D8EE47B0655C516E9CE6402867258C@shsmsx102.ccr.corp.intel.com> References: <36DF59CE26D8EE47B0655C516E9CE6402867258C@shsmsx102.ccr.corp.intel.com> Date: Tue, 10 Nov 2015 15:04:28 +0200 Message-ID: Subject: Re: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support From: Andy Shevchenko To: "Chen, Yu C" Cc: "Zheng, Lv" , Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Wysocki, Rafael J" , "Brown, Len" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 20 On Tue, Nov 10, 2015 at 11:42 AM, Chen, Yu C wrote: > Hi, Lv > Sorry for my late feedback on the patch, one minor nit below: >> + start_pfn = page_to_pfn(virt_to_page(pointer)); >> + end_pfn = page_to_pfn(virt_to_page(pointer + length)); > Convert pointer to char* first? > end_pfn = page_to_pfn(virt_to_page((char*)pointer + length)); Why do you need that? void * + size_t = char * + size_t -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/